Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-50380] checkedCast should just return object when assignable #192

Merged
merged 3 commits into from Mar 28, 2018
Merged

[JENKINS-50380] checkedCast should just return object when assignable #192

merged 3 commits into from Mar 28, 2018

Conversation

abayer
Copy link
Member

@abayer abayer commented Mar 27, 2018

JENKINS-50380

Downstream of jenkinsci/groovy-sandbox#45

cc @reviewbybees

@abayer abayer requested review from jglick and svanoort March 27, 2018 19:26
@abayer abayer changed the title [JENKINS-50380] checkedCast should use clazz.cast when assignable [JENKINS-50380] checkedCast should just return object when assignable Mar 27, 2018
svanoort
svanoort approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@svanoort svanoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ok

@abayer abayer merged commit c9ecc79 into jenkinsci:master Mar 28, 2018
@abayer abayer mentioned this pull request Mar 28, 2018
Merged
@dwnusbaum dwnusbaum mentioned this pull request Aug 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@svanoort svanoort svanoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@abayer @jglick @svanoort