JENKINS-59952: Whitelisting all remaining java.util.regex methods #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
approved these changes
Oct 28, 2019
|
I only observed those that are already known, so yes, none of these that I am adding showed up there. |
bitwiseman
approved these changes
Oct 28, 2019
|
Could someone please kick off the build again? It seems there was some error with the build. |
|
Yes, there seemed to be a transient issue, but couldn't find an option on the Jenkins interface. I could try pushing an empty commit. |
|
Very few users have permission to trigger a build on ci.jenkins.io directly. If you want to rebuild a PR, you can close the PR, wait a few seconds, and then reopen it. Assuming ci.jenkins.io is up and running, that will trigger a new build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that all the methods from java.util.regex package are whitelisted. There is no functionality in this package that touches external resources, so everything should be safe to be whitelisted.