Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Dependabot to ignore Caffeine 3.x due to Java 11 requirement #332

Merged
merged 1 commit into from Feb 24, 2021

Conversation

dwnusbaum
Copy link
Member

@dwnusbaum dwnusbaum commented Feb 24, 2021

See #331 and https://github.com/ben-manes/caffeine/releases/tag/v3.0.0.

We cannot update caffeine to 3.0.0 until a version of Jenkins that requires Java 11 is released and we are ready to update the minimum supported Jenkins version here in script-security to that version.

Maybe it would make sense to try to replace the caffeine dependency with a small API on top of ConcurrentHashMap or similar if we are not going to be able to update the dependency for a long time. Personally, I am not as concerned about the performance of the caching layer (at least as long as the performance is not terrible) as I am about its correctness, so from my PoV the main benefit of switching to caffeine in #160 was that we could avoid the concurrency-related issues we were occasionally seeing with the Guava cache (admittedly, Jenkins is using a very old version of Guava).

Closes #331.

@dwnusbaum dwnusbaum merged commit d02d0d9 into jenkinsci:master Feb 24, 2021
@dwnusbaum dwnusbaum deleted the ignore-caffeine branch February 24, 2021 21:22
@ben-manes
Copy link

Caffeine 2.x will continue to be supported on Java 8. That likely won't include new features, but will have bug fixes and similar improvements. The major bump was not meant to imply that we are going to abandon users, but was needed to support those who want us to use VarHandles (Java 9+). The major version provided the ability to do minor clean up and other fixes that can't be done incrementally in a semver's minor/patch cycle. We'll continue making releases for 2.x as issues are found, though with a tendency to not backport major new functionality unless requested, discussed, and semver compatible.

@dwnusbaum
Copy link
Member Author

@ben-manes Ok, thanks for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants