use https instead of git

[programbeginnerTW]

use https protocol instead of git protocol because Github is deprecating git protocol

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did

[damianszczepanik]

Share the announcement about it

[programbeginnerTW]

@damianszczepanik I've created a new post here !

Greetings!

[MarkEWaite]

Thanks for the proposed change, but as far as I can tell, the change is unnecessary.

The transition from git protocol to https protocol is needed when the protocol is declared as git://. That transition is needed because GitHub no longer supports the unauthenticated git:// protocol. Read the GitHub blog post for more details.

This is proposing to change the protocol from ssh:// to https://. While that change is not harmful, it is not consistent with the title of the pull request and does not provide significant benefit in functionality.

An example of the cases where a transition from git:// to https:// is included in the Jenkins tutorial

[damianszczepanik]

Recently I had problems because of invalid protocol https://github.com/jenkinsci/sidebar-link-plugin/pull/63/files - the problem occurs only during release goal but not at the compile/test/verification stage

[MarkEWaite]

Recently I had problems because of invalid protocol https://github.com/jenkinsci/sidebar-link-plugin/pull/63/files - the problem occurs only during release goal but not at the compile/test/verification stage

Thanks for the clarification. The plugin archetype uses https, so no objections from me that this plugin uses https. When I generated an empty plugin from the archetype, the scm section looked like this:

    <connection>scm:git:https://github.com/${gitHubRepo}</connection>
    <developerConnection>scm:git:https://github.com/${gitHubRepo}</developerConnection>
    <tag>${scmTag}</tag>
    <url>https://github.com/${gitHubRepo}</url>

Anything that brings plugins closer to the syntax used by the plugin archetype is great for me.

[MarkEWaite]

The username portion of the URL is not included in the plugin archetype. The .git suffix is not included in the connection either. Optionally may want to remove those two differences so that the differences between the plugin and the archetype are reduced.

Suggested change

	<connection>scm:git:https://git@github.com/${gitHubRepo}.git</connection>
	<connection>scm:git:https://github.com/${gitHubRepo}</connection>

[damianszczepanik]

Since this can be tested only during the release process I will accept only configuration that was proven during the release, eg https://github.com/damianszczepanik/maven-cucumber-reporting/blob/master/pom.xml