Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filepath validation performed on the
doCheckLinkIcon
needed some improvement, it was still allowing to discover if a directory calleduserContent[RandomString]
existed. Which I agree, is an edge case that will never happen in the real world.To fix that, I simply added a file separator to the
userContent
definition to avoid this behavior.Testing done
Create a directory called
userContent2
at the same level as theuserContent
one and called:I also tested that it was still working for a correct usage, e.g: