Support build from webhook #22
Conversation
| } | ||
|
|
||
| @Extension | ||
| public static class GhprbRootActionCrumbExclusion extends CrumbExclusion { |
There was a problem hiding this comment.
Class has not been renamed
|
|
||
| public void doIndex(StaplerRequest req, | ||
| StaplerResponse resp) { | ||
| List<WorkflowMultiBranchProject> projects = Jenkins.get().getItems(WorkflowMultiBranchProject.class); |
There was a problem hiding this comment.
It won't work as you expect. Even if the action itself is not protected, this method should have permission checks inside
There was a problem hiding this comment.
Can you suggest something using which I can do the same thing and permissions are taken care of.
| import java.util.logging.Logger; | ||
|
|
||
| /** | ||
| * @author Honza Brázdil jbrazdil@redhat.com |
| * @author Honza Brázdil jbrazdil@redhat.com | ||
| */ | ||
| @Extension | ||
| public class YamlRootAction implements UnprotectedRootAction { |
There was a problem hiding this comment.
@Restricted(NoExternalUse.class)
| // Hence triggering branch indexing of all projects, it will create jobs for new branches and pull requests and | ||
| // delete jobs of closed pull requests. | ||
| for(WorkflowMultiBranchProject project: projects){ | ||
| if(project.getProjectFactory().getDescriptor().getDisplayName().equals(YamlRootAction.BUILD_CONFIGURATION_MODE)) { |
There was a problem hiding this comment.
🐛 Checking against display name is unreliable. It will start failing once the string is localized
There was a problem hiding this comment.
I can use something else here. I will take care of this.
| @Extension | ||
| public class YamlRootAction implements UnprotectedRootAction { | ||
|
|
||
| static final String URL = "yamlhook"; |
There was a problem hiding this comment.
maybe we need a more specific URL including artifactId
| import java.util.List; | ||
|
|
||
| /** | ||
| * @author Abhishek Gautam gautamabhishek46 |
There was a problem hiding this comment.
this author tag is only used here in your plugin - if you're not going to use it everywhere, than I think this shouldn't be here
| } | ||
|
|
||
| @Extension | ||
| public static class YamlRootActionCrumbExclusion extends CrumbExclusion { |
There was a problem hiding this comment.
Can you please write a javadoc telling what is the purpose of this inner class?
See JENKINS-51941