Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the plugin name and the yaml file name for future compatibility #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gautamabhishek46
Copy link
Contributor

Copy link

@grandvizier grandvizier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I don't think this comes close to meeting the acceptance criteria for JENKINS-52663

But with regards to being a small change that improves things, I think this PR is good. I'd just suggest changing the title Change the plugin name and the yaml file name for future compatibility to be more clear that you're just changing the default script name.

@kwhetstone
Copy link

I'm not seeing the plugin name change here. Also, I'd suggest flowing the name out on the list first before making the PR so you're not having to make this change again.

@gautamabhishek46
Copy link
Contributor Author

gautamabhishek46 commented Aug 12, 2018

Plugin name can be "YAML Pipeline Builder".
We can have the same repo and Gitter room, for now, I guess.
Alpha versions are independent of the actual release, hence they can exist as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants