Issue #39: if option is active, the list of commits is shown... #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is patching #30. Just adding it as a reference. |
|
Can you amend your commit message so that it has a short title about 50 chars long, a blank line, and then a more descriptive message? e.g. It helps when viewing the git tree from the terminal. Just... |
As opposed to just for successful builds previously.
|
Sure. Thanks for the initiative and good work, Sam! |
|
No problem. FYI I don't plan to do much active development. I'll mostly just be maintaining incoming pull requests and releases. |
samrocketman
added a commit
that referenced
this pull request
Feb 4, 2015
samrocketman
added a commit
that referenced
this pull request
Feb 10, 2015
New features:
* Advanced settings
* Team domain and token can be specified per project; falls back to
global config if not specified (#19)
* Post a list of commits with the build notification (title and author
of commit) (#30, #44, #45)
* Include JUnit test summary in build notifications (#25)
* Use colors when sending a message using slack (#20, #24). Also, the
start notifications use the color of the last build result (#43)
* Support for authenticated proxies (#14)
* Test Connection button (#46, #28)
* Option to disable subsequent notifications on build failures (#46, #15)
Improvements:
* Report 'return to normal' on transition from unstable to success (#21)
* Improved logging.
Bug fixes:
* When changing the global slack settings the slack config in jobs are
updated as well (#26, #12)
* Fix NullPointerException and output log message if slack is not
configured (#35, JENKINS-26066)
alexey-pelykh
pushed a commit
to brainbeanapps/slack-plugin
that referenced
this pull request
Nov 3, 2016
getKeychain returns a global keychain preferred over a local path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... after ANY build (as opposed to only successful builds previously)