Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom messages per Build result #445

Merged
merged 3 commits into from Dec 17, 2018

Conversation

KreAch3R
Copy link
Contributor

@KreAch3R KreAch3R commented Dec 16, 2018

Following #169 #385

I re-wrote this patch for the current master source.

While I'm there, sync the notify booleans with the custom message boxes.

Closes #163
Closes #360
Closes #284
Closes #212

pom.xml Outdated Show resolved Hide resolved
@timja
Copy link
Member

timja commented Dec 17, 2018

@KreAch3R I've linked all the related issues in your description so that when this gets merged they will all get closed

Original idea from jenkinsci#169
(Enhance Custom Message Functionality by @csogilvie)

Discussion in jenkinsci#385

I re-wrote it almost completely on top of the current master
@timja timja merged commit 72d41da into jenkinsci:master Dec 17, 2018
@@ -594,7 +656,13 @@ public SlackJobProperty(String teamDomain,
boolean includeTestSummary,
boolean showCommitList,
boolean includeCustomMessage,
String customMessage) {
String customMessage,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, I can't believe this made it through. adding stuff to a deprecated class feels wrong 😅 @timja @KreAch3R

Copy link
Member

@timja timja Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm oops misread that..

@Wei-Lin-D
Copy link

I'm sorry but has this feature ever been released?
We are in version 2.3 but seems there still no ways to toggle on/off custom messages for each result.
How can we use this feature?
スクリーンショット 2019-10-03 19 07 12

@timja
Copy link
Member

timja commented Oct 3, 2019

2.3 is about 2 years old I think... you can have a look at releases to see details

@Wei-Lin-D
Copy link

Wei-Lin-D commented Oct 4, 2019

2.3 is about 2 years old I think... you can have a look at releases to see details

Thank you for your reply!! 😄
While actually v2.30 was released on 16 Aug from the releases page...
And the latest version is v2.34 which was released 14 days ago.
This feature should be included in v2.30?

@timja
Copy link
Member

timja commented Oct 4, 2019

You said you were using 2.3...
This feature was added ages ago, just use the latest version

@Wei-Lin-D
Copy link

You said you were using 2.3...
This feature was added ages ago, just use the latest version

Oh, my bad, I just got the version wrong (2.3 and 2.30) 😆
Updated the plugin and now we can set custom messages for each build result.
Nice feature, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants