[JENKINS-44830] NPE after upgrading caused by fix of JENKINS-42959 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Jun 12, 2017
| public SshHostKeyVerificationStrategy getSshHostKeyVerificationStrategy() { | ||
| return sshHostKeyVerificationStrategy; | ||
| } | ||
|
|
||
| @NonNull | ||
| SshHostKeyVerificationStrategy getSshHostKeyVerificationStrategyDefaulted() { |
There was a problem hiding this comment.
makes sense to make public later
There was a problem hiding this comment.
Only if there are some external callers—currently I do not see a need for it.
|
@reviewbybees done |
daniel-beck
approved these changes
Jun 12, 2017
Nope, if the |
stephenc
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-44830
Amends #54. Reproduces reported NPE.
@reviewbybees