Jakarta EE 9 transition #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Dec 19, 2021
core/src/test/java/org/kohsuke/stapler/compression/CompressionFilterTest.java
Outdated
Show resolved
Hide resolved
jruby/src/main/java/org/kohsuke/stapler/jelly/jruby/RackDispatcher.java
Outdated
Show resolved
Hide resolved
basil
force-pushed
the
jakarta
branch
6 times, most recently
from
e55024e
to
abb651f
Compare
basil
force-pushed
the
jakarta
branch
2 times, most recently
from
11d80dd
to
63ff5e7
Compare
basil
force-pushed
the
jakarta
branch
2 times, most recently
from
2bc6075
to
7efd583
Compare
basil
force-pushed
the
jakarta
branch
3 times, most recently
from
fdbbbea
to
d55122e
Compare
jglick
reviewed
Aug 4, 2022
| import jakarta.servlet.RequestDispatcher; | ||
| import jakarta.servlet.ServletContext; | ||
| import jakarta.servlet.ServletException; | ||
| import jakarta.servlet.http.HttpServletRequest; |
There was a problem hiding this comment.
Note for myself and other reviewers more than author: this is binary-incompatible (jenkinsci/jenkins#6085 (comment)). As in jenkinsci/jenkins#4848, japicmp may be helpful for summarizing the incompatible changes in the current revision, to make it easier to see whether they are in widely used types.
|
I am not interested in reviews, nor am I committing to completing this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/jelly#8. A fairly hacky prototype of the Jakarta EE 9 transition, but one which uncovered a few interesting action items.