Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml: Use Apache HttpComponents Client 4.x API Plugin #120

Merged
merged 2 commits into from
Aug 5, 2019

Conversation

proski
Copy link

@proski proski commented Jul 12, 2019

*  pom.xml: Use Apache HttpComponents Client 4.x API Plugin
   
   This removes httpclient-4.5.2.jar and httpcore-4.4.4.jar from the plugin
   package, cutting its size by almost a megabyte.
   
   Users can update the Apache HttpComponents plugin on their own without
   waiting on other plugins to update.
   
   Apache HttpComponents plugin, is likely to be installed already because
   it's used by git plugin.

Let's share this dependency like most modern plugins do. No need to bundle our own copy.

@proski proski force-pushed the httpclient-plugin branch 2 times, most recently from 1858f44 to a4431a2 Compare July 22, 2019 06:45
All recent versions of HttpClient API and Jackson2 API plugins require
2.60.3. It's not a significant requirement change.
This removes httpclient-4.5.2.jar and httpcore-4.4.4.jar from the plugin
package, cutting its size by almost a megabyte.

Users can update the Apache HttpComponents plugin on their own without
waiting for other plugins to update their dependencies.

Apache HttpComponents plugin is likely to be installed already because
it's used by the git plugin.
@jakub-bochenski jakub-bochenski merged commit 7271542 into jenkinsci:master Aug 5, 2019
@proski proski deleted the httpclient-plugin branch August 5, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants