Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StatisticsConfiguration.java #24

Merged
merged 1 commit into from Feb 6, 2019
Merged

Conversation

rdpa
Copy link

@rdpa rdpa commented Oct 26, 2018

Don't force appending a slash to URLs. Fixes https://issues.jenkins-ci.org/browse/JENKINS-54279

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 63.065% when pulling f61d4f3 on rdpa:patch-1 into 29fdbe3 on jenkinsci:master.

@darxriggs
Copy link

Hi @lucamilanesio is there anything else required to get this merged?

@lucamilanesio
Copy link
Member

Sorry, I missed it, will have a look over the weekend.

@lucamilanesio
Copy link
Member

@darxriggs it seems that @maximecharron put that logic in the past to fix a SonarQube issue (see 5bc4723). Not sure exactly why a trailing slash should matter for SonarQube, but let's wait for a few days to see if @maximecharron remembers anything about it.

If I am not hearing anything from him within a few days, I'll merge it as-is.

@darxriggs
Copy link

@lucamilanesio I already had a look at the file's history to understand why the trailing slash functionality is in place. Unfortunately it's present since the initial commit 937faf6 and therefore it's not clear why. The commit you referenced is about something different.

I strongly vote for this PR, not to automatically add a trailing slash. If a trailing slash is required for an endpoint a user can just configure it accordingly. Otherwise adding query parameters as described in the Jira ticket is not possible.

Type Value
original http://example.org/some-path?param1=test
modified http://example.org/some-path?param1=test/

@lucamilanesio lucamilanesio merged commit e3096a1 into jenkinsci:master Feb 6, 2019
@rdpa rdpa deleted the patch-1 branch February 6, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants