Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for map and parametric types #80

Closed
wants to merge 1 commit into from
Closed

Add support for map and parametric types #80

wants to merge 1 commit into from

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Feb 21, 2021

This new parameter type could be consumed by the steps docs generator or snippetizer.

@zbynek zbynek changed the title Add support for map parameters Add support for map and parametric types Feb 21, 2021
@zbynek
Copy link
Contributor Author

zbynek commented Mar 2, 2021

@car-roll could you please check this PR?

@car-roll
Copy link
Contributor

car-roll commented Mar 4, 2021

Hi @zbynek I this PR is trying to do the same as #52
There were a couple of important points raised in that discussion, it would probably be worthwhile to take a look at the various discussions that happened over there. In particular, the ones here:
#52 (review)
#52 (comment)

Long story short, Map is not a legal binding type and adding support for map and other parameterized types has implications that go beyond this plugin

@zbynek zbynek closed this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zbynek @car-roll