Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Digester dep #259

Merged
merged 1 commit into from Jun 15, 2021
Merged

Remove Digester dep #259

merged 1 commit into from Jun 15, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 15, 2021

Alternative to #254 + #255 + #257 + #258.

@jglick jglick mentioned this pull request Jun 15, 2021
Closed
@timja timja merged commit d2926d0 into jenkinsci:master Jun 15, 2021
@jglick jglick deleted the digester branch June 15, 2021 11:48
This was referenced Jun 15, 2021
Closed
Merged
@bitwiseman
Copy link
Contributor

@jglick
Could you write a paragraph to describe what you did here and I'll integrate it into JEP-231.

@jglick
Copy link
Member Author

jglick commented Jun 15, 2021

https://github.com/jenkinsci/jep/blob/master/jep/231/README.adoc#example-change-to-plugin-code already mentions this.

@bitwiseman
Copy link
Contributor

bitwiseman commented Jun 15, 2021 •
edited

@jglick
Yes, it mentions it, but doesn't explain what is being done. It looks pretty straight-forward, but like I said if you could take a minute to write a few sentences explaining your changes (since there are no comments in the code) that could help others to do the same more quickly in the future.

@jglick jglick mentioned this pull request Jun 15, 2021
Merged
theKBro pushed a commit to theKBro/subversion-plugin that referenced this pull request Jun 24, 2021
@jglick
Remove Digester dep (jenkinsci#259)
5d2aecc
@jglick jglick mentioned this pull request Dec 20, 2021
Merged
10 tasks
@basil basil mentioned this pull request Dec 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
4 participants
@jglick @bitwiseman @basil @timja