Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-60805] Restore binary compatibility #207

Merged
merged 1 commit into from Jan 18, 2020

Conversation

varyvol
Copy link

@varyvol varyvol commented Jan 17, 2020

Fixes JENKINS-60805 by reverting the signature of the API that was changed in 2.66.

@varyvol varyvol changed the title [JENKINS-60805] Restore binary compatibility. [JENKINS-60805] Restore binary compatibility Jan 17, 2020
Copy link
Member

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but I am not sure to fully understand the hack with the NonExistentComponent

@varyvol
Copy link
Author

varyvol commented Jan 17, 2020

@aheritier you cannot create empty extension lists or remove objects from them. So I request one with a component I know that doesn't have any extension and then plug into it the components I'm interested in.

@aheritier
Copy link
Member

whaouu. Thx @varyvol

Copy link
Member

@aheritier aheritier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test and reproduce the issue with the previous version of the plugin.
I confirm that this fix is restoring the compatibility with Advisor
Thanks a lot @varyvol

@varyvol
Copy link
Author

varyvol commented Jan 18, 2020

Given this is causing issues, I'm merging and releasing it already.

@varyvol varyvol merged commit 0aec6e6 into jenkinsci:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants