Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-60010] OtherLogs should not include GC Logs if activated with the JVM #303

Merged
merged 4 commits into from Aug 23, 2021
Merged

[JENKINS-60010] OtherLogs should not include GC Logs if activated with the JVM #303

merged 4 commits into from Aug 23, 2021

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Aug 20, 2021 •
edited

JENKINS-60010:

  • made GCLogs#isGcLogRotationConfigured and GCLogs#getGcLogFileLocation public
  • Filter out GC Logs from Other Logs component if the GC Logs are configured for the JVM
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Dohbedoh Dohbedoh changed the title Jenkins 60010 [JENKINS-60010] OtherLogs should not include GC Logs if activated with the JVM Aug 20, 2021
@Dohbedoh Dohbedoh added the bug label Aug 20, 2021
res0nance
res0nance approved these changes Aug 22, 2021
View reviewed changes
Copy link
Contributor

@res0nance res0nance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice the tests look good!

src/main/java/com/cloudbees/jenkins/support/impl/OtherLogs.java Outdated Show resolved Hide resolved
Dohbedoh and others added 2 commits August 23, 2021 10:24
@Dohbedoh
[JENKINS-60010] Fix tests for JDK 11
1c3c526
@Dohbedoh @res0nance
[JENKINS-60010] Fix typo
a18b8e3 
Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com>
@MRamonLeon MRamonLeon merged commit 77b5519 into jenkinsci:master Aug 23, 2021
@Dohbedoh Dohbedoh deleted the JENKINS-60010 branch December 29, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRamonLeon MRamonLeon MRamonLeon approved these changes

@res0nance res0nance res0nance approved these changes

@duemir duemir Awaiting requested review from duemir

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@Dohbedoh @MRamonLeon @res0nance