Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70351] Fix initialization and deprecate obsolete SupportContext #420

Merged
merged 1 commit into from Dec 29, 2022

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Dec 29, 2022

JENKINS-70351

  • Removed the SupportPlugin#postInitialize that happens on plugin startup
  • Deprecate the SupportContext that the SupportPlugin#postInitialize is setting as it is obsolete / unused since 5905c4f.
  • Add an @Initializer(after = InitMilestone.EXTENSIONS_AUGMENTED, before = InitMilestone.SYSTEM_CONFIG_LOADED) to the CustomLogs.CustomLogHandler. For some reason, this was done via Component#start(SupportContext) though not related to the SupportContext.
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Dohbedoh Dohbedoh requested a review from a team as a code owner December 29, 2022 03:06
@Dohbedoh Dohbedoh added the bug label Dec 29, 2022
@Dohbedoh Dohbedoh merged commit 32a39d7 into jenkinsci:master Dec 29, 2022
@Dohbedoh Dohbedoh deleted the JENKINS-70351 branch December 29, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant