Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-26558] Clients should provide a unique ID to be used for ... #26

Merged
merged 9 commits into from Apr 27, 2015

Commits on Apr 24, 2015

  1. [FIXED JENKINS-26558] Clients should provide a unique ID to be used f…

    …or name collision avoidance
    
    - The current name collision avoidance uses the requests address, which could very likely be the same for all clients
      as they could be being routed through a HTTP proxy (or two) so that is not a good disambiguator
    - We use a digest of the client's interfaces and MAC addresses and the remoteFSRoot to try and give a consistent ID
    - We ALWAYS append the ID if we have it as otherwise during reconnect the slaves with the same name will shuffle around
      which defeats a lot of the login that Jenkins has internally based on slaves having a consistent name
    - In the event of legacy clients that do not have the ID we will let them connect with their name as long as there
      is no online slave with that name. This does mean that where there are multiple legacy swarm clients with the
      same name, only one can be on-line at any moment in time, but that is an improvement on the current where
      once a shuffle starts, none can stay on-line
    stephenc committed Apr 24, 2015
    Configuration menu
    Copy the full SHA
    ab37bc8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0871658 View commit details
    Browse the repository at this point in the history
  3. extra null safety

    stephenc committed Apr 24, 2015
    Configuration menu
    Copy the full SHA
    2132772 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2015

  1. Configuration menu
    Copy the full SHA
    7984ef2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    640637c View commit details
    Browse the repository at this point in the history
  3. Explain what's going wrong

    stephenc committed Apr 27, 2015
    Configuration menu
    Copy the full SHA
    78c8650 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b7e1470 View commit details
    Browse the repository at this point in the history
  5. Specify locale

    stephenc committed Apr 27, 2015
    Configuration menu
    Copy the full SHA
    ff5dd53 View commit details
    Browse the repository at this point in the history
  6. oops missed the charset fix

    stephenc committed Apr 27, 2015
    Configuration menu
    Copy the full SHA
    96a1a84 View commit details
    Browse the repository at this point in the history