New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED JENKINS-26558] Clients should provide a unique ID to be used for ... #26
Merged
Commits on Apr 24, 2015
-
[FIXED JENKINS-26558] Clients should provide a unique ID to be used f…
…or name collision avoidance - The current name collision avoidance uses the requests address, which could very likely be the same for all clients as they could be being routed through a HTTP proxy (or two) so that is not a good disambiguator - We use a digest of the client's interfaces and MAC addresses and the remoteFSRoot to try and give a consistent ID - We ALWAYS append the ID if we have it as otherwise during reconnect the slaves with the same name will shuffle around which defeats a lot of the login that Jenkins has internally based on slaves having a consistent name - In the event of legacy clients that do not have the ID we will let them connect with their name as long as there is no online slave with that name. This does mean that where there are multiple legacy swarm clients with the same name, only one can be on-line at any moment in time, but that is an improvement on the current where once a shuffle starts, none can stay on-line
Configuration menu - View commit details
-
Copy full SHA for ab37bc8 - Browse repository at this point
Copy the full SHA ab37bc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0871658 - Browse repository at this point
Copy the full SHA 0871658View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2132772 - Browse repository at this point
Copy the full SHA 2132772View commit details
Commits on Apr 27, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 7984ef2 - Browse repository at this point
Copy the full SHA 7984ef2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 640637c - Browse repository at this point
Copy the full SHA 640637cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78c8650 - Browse repository at this point
Copy the full SHA 78c8650View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7e1470 - Browse repository at this point
Copy the full SHA b7e1470View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff5dd53 - Browse repository at this point
Copy the full SHA ff5dd53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96a1a84 - Browse repository at this point
Copy the full SHA 96a1a84View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.