Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow --detect.excluded.directories to work correctly again with wildcards like v7 #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

isaac84
Copy link

@isaac84 isaac84 commented Jun 8, 2023

Don't escape asterisk '*' in DetectScriptStrategy so wildcards can correctly work again for --detect.excluded.directories
See https://community.synopsys.com/s/article/detect-excluded-directories-doesn-t-work

The workaround wasn't an option for us as unfortunately our repo is messy and there are about 100 directories that need to be excluded. Using a static list would be unmaintainable in our situation.

Testing done

Updated the existing DetectScriptStrategyTest to verify that '*' are not escaped, and tested this then allows the --detect.excluded.directories option to work correctly in our Jenkins builds (it does). Note: however we build with Linux so powershell was not tested in Jenkins.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant