Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-29649] Now JUnit and TAP publisher do not clash with each other trying to draw plots on a project page #13

Merged
merged 1 commit into from
Aug 19, 2016

Conversation

anenviousguest
Copy link

TapTestResultAction was derived from hudson.tasks.test.TestResultProjectAction.TestResultAction

And hence this check was inherited too: https://github.com/jenkinsci/junit-plugin/blob/master/src/main/java/hudson/tasks/junit/TestResultAction.java#L96

With that said, when building a project page, JUnit's and TAP's test result actions were mutually exclusive to each other.

…ach other trying to draw a plot on a project page.
@kinow
Copy link
Member

kinow commented Aug 19, 2016

Hey @anenviousguest, excellent job! I'm checking out the project to build it. But thanks for the neat code, and for including tests! 👍

@kinow kinow merged commit bc46bc5 into jenkinsci:master Aug 19, 2016
@kinow
Copy link
Member

kinow commented Aug 19, 2016

Tested locally the master branch. Created a job with JUnit and TAP. Confirmed the JUnit "Test Result" link in the sidebar is not displayed. No error messages in console.

Installed the .hpi file from this pull request. Opened the TAP action pages, no errors in console or web page. Still no JUnit Test Result link.

Re-executed the job, this time the plug-in correctly handled TAP and JUnit, and now I can see the TAP links in the sidebar, and also the JUnit action. No errors, all looking good. Changes merged, included in the next release. Thanks @anenviousguest !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants