-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a display of subtest in TAP Extended Test Results view #18
base: master
Are you sure you want to change the base?
Conversation
…ipse reformating)
…ormations). indentation is perform in the status column for each sub test
Thanks @guilcy !!! I noticed you are still working on it, so added a [WIP] marker. Feel free to remove it once you are done, and I will know we can review it. Thanks!!! |
Well, yes I did some new motifications in my fork, I though this would not be visible in the pull request (I am new with using the tool). Basically even if the rendering is much nicer with the last changes (and the coding better) , as I did not find how to make recursivity into Jelly, I replicate one Jelly script 5 times to match the sub test levels ( due to this it is limited to 5 levels of subtest), this is ugly (I would prefer a nice Jelly trick instead), or a another solution would reside in changes in the java (add an interface) to render a testSet, flattend, with indent information in each tapLines (or tapElement). |
You are doing great! Your pull request is not hard to review (i.e. you are not changing things outside the scope of your change like formatting, code style, etc). The code looks good. I'm a bit concerned about the limitations you pointed, but happy to compromise if it doesn't impact users.
I can review the Jelly later, or we can look at the Groovy examples now. I wrote the code some years ago (even before publishing, I was using in a company while writing tap4j), so there are probably a few parts of the code that can be improved (I know for certain that memory usage has to be reduced, for that someone needs to rewrite the junit integration to not load so many objects in memory... but digressing here.. sorry)
Not sure. Normally I would have Jelly file A, calling Jelly file B in a loop. If A needed to call A... well... I am not sure what would happen :-) |
The need is really Jelly A call Jelly A... and this is causing a crash inside Jenkins. |
I have pushed a new commit to fix a typo in jelly script which cause problem on recent jenkins (but works fine on my dev/debug setup). |
I modified the jelly code to render one level of subtest when flatten result not checked.
Unfortunately I did not succeed in having a recursive display all the subtests (I am newbe in jelly), even if it may become very difficult to read, I would like to improve this (lot of space is lost in the indentation methode I used, and the number of subtest is now in the Description column.
Another possibility could be to display subtests only after click on the parent.
If flatten result is checked the subtests are rendered the old way.