Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 11 and Jenkins 2.361.4 or newer #74

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Nov 3, 2021

Require Jenkins 2.361.4 or newer, use plugin bill of materials

  • Use GitHub README for plugins.jenkins.io docs
  • Update for Jenkins 2.361.4 and Java 11
  • Simplify dependencies with Jenkins plugin bill of materials
  • Reduce plugin hpi file size by depending on Jenkins API plugins

See the "Improve a plugin" tutorials for the videos that describe the rationale behind those changes.

Removes the need for the following two pull requests:

@MarkEWaite MarkEWaite changed the title Use GitHub for plugins.jenkins.io docs Move documentation into the GitHub repository Feb 6, 2023
https://www.jenkins.io/doc/developer/publishing/documentation/
describes the process to change from wiki based plugin documentation
to host the plugin documentation in GitHub.

In this case, the preferred plugin documentation location seems to be
the bitbar.com site.  Will adjust the README to first include a link
to the bitbar.com site while retaining the other information in the
README.
Guava in Jenkins is now running very recent versions.  No need to package
Guava in this plugin.

Java 11 is the minimum Java version since Jenkins 2.361.1.  no need to
declare it.

Tool versions are all current and remain updated.
@MarkEWaite MarkEWaite force-pushed the use-github-for-plugins-jenkins-io-docs branch from 8d9b8d0 to 70f8db3 Compare June 16, 2023 02:11
@MarkEWaite MarkEWaite changed the title Move documentation into the GitHub repository Update plugin for Jenkin s2.387.3, latest pom, and plugin bill of materials Jun 16, 2023
@MarkEWaite MarkEWaite changed the title Update plugin for Jenkin s2.387.3, latest pom, and plugin bill of materials Update plugin for Jenkins 2.387.3, latest pom, and plugin bill of materials Jun 16, 2023
The plugin already requires Java 11. Jenkins 2.361.1 is
the first long term support release that requires Java 11.
https://www.jenkins.io/blog/2022/06/28/require-java-11/ announced that
change in June 2022.

https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
recommends choosing the terminal release (2.361.4) rather than choosing the
initial release in an LTS baseline, so 2.361.4 was chosen instead of 2.361.1.

https://stats.jenkins.io/pluginversions/testdroid-run-in-cloud.html shows
that users of this plugin running Jenkins versions that require Java 11
(2.357 weekly or newer, 2.361.1 LTS or newer) are already running Jenkins
2.375.2 or newer.  This change does not create any barrier for their
upgrade to a release based on this change.  They are already running a
newer version than the minimum Jenkins version required by this change.

Declares dependency on several Jenkins API plugins for testdroid-api
rather than relying on Maven to bundle the transitive dependencies.
This reduces the size of the plugin hpi file and allows Jenkins users to
run with the more recent API version rather than requiring a new release
of this plugin.

Earlier changes in this pull request removed the bundling of guava since
a modern guava version is provided with Jenkins core.  Those dependency
changes have reduced the plugin hpi file from over 10 MB to less than
5 MB.
@MarkEWaite MarkEWaite changed the title Update plugin for Jenkins 2.387.3, latest pom, and plugin bill of materials Require Jenkins 2.361.4 or newer Aug 20, 2023
@MarkEWaite
Copy link
Contributor Author

MarkEWaite commented Aug 20, 2023

@arturCwiklinsky this pull request simplifies the maintenance of plugin dependencies and reduces the number of dependencies that are bundled into the plugin.

@MarkEWaite MarkEWaite changed the title Require Jenkins 2.361.4 or newer Require Java 11 and Jenkins 2.361.4 or newer Aug 28, 2023
@szprutamich szprutamich merged commit ca6265e into jenkinsci:master Sep 28, 2023
10 checks passed
Plugin documentation Migration (Wiki=>GitHub) automation moved this from In progress to Merged Sep 28, 2023
@MarkEWaite MarkEWaite deleted the use-github-for-plugins-jenkins-io-docs branch October 5, 2023 23:16
@zbynek zbynek moved this from Merged to Released in Plugin documentation Migration (Wiki=>GitHub) Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants