Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JENKINS-32746: Change loop determination condition in order to check all loaded builds #29

Merged
merged 1 commit into from May 14, 2017
Merged

Fix JENKINS-32746: Change loop determination condition in order to check all loaded builds #29

merged 1 commit into from May 14, 2017

Conversation

juherr
Copy link
Contributor

@juherr juherr commented Apr 24, 2017

No description provided.

@juherr
Copy link
Contributor Author

juherr commented Apr 28, 2017 •
edited by batmat

Ping @jenkinsci/code-reviewers

@batmat
Copy link
Member

batmat commented Apr 28, 2017

Test @jenkinsci/code-reviewers

@batmat
Copy link
Member

batmat commented Apr 28, 2017

Weird, the first ping @juherr was inactive, and became bold and clickable when I edited it. But still not visible in https://github.com/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+team%3Ajenkinsci%2Fcode-reviewers
I became listed in the link above when I added the last comment...

Wasn't aware that there was possibly something like access rights for pinging some GitHub team? That would somehow defeat the purpose of this one BTW.

@batmat
Copy link
Member

batmat commented Apr 28, 2017

So, apparently it's normal IIUC:
image

As @juherr is not (yet :-)) part of the jenkinsci GH org.

oleg-nenashev
oleg-nenashev approved these changes Apr 30, 2017
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@juherr
Copy link
Contributor Author

juherr commented May 13, 2017

@batmat @batmat Someone could merge? :)

@oleg-nenashev
Copy link
Member

@nullin Hi, it would be great to get a feedback from you

@nullin
Copy link
Member

nullin commented May 14, 2017 •
edited

lgtm!

btw, @juherr, this project is now orphaned. Someone needs to take over and ensure this fix is actually released.

Best!

@nullin nullin merged commit c9c17fe into jenkinsci:master May 14, 2017
@juherr juherr deleted the JENKINS-32746 branch September 3, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@juherr @batmat @oleg-nenashev @nullin