Upgrade plugin to parent version 1.424 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 - Extracted the getExclusiveToTimestamp() method to prevent copy-pasting. 2 - Extracted the getRangeSpecification() method to remove duplication and add support for changesets. 3 - Added new constructor overloads. 4 - Made the CC-735 workaround more consistent between both the detailed and brief history implementations, and added support for fromTimestamp being null. 5 - Added tests.
1 - Added getBriefHistory() method overload that wraps command when querying from a given changeset. 2 - Added TODOs for upcoming work.
|
Jenkins » tfs-plugin #12 SUCCESS |
In those cases, baseline is SCMRevisionState.None and thus we fall back to the old polling method.
|
Jenkins » tfs-plugin #13 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| <artifactId>plugin</artifactId> | ||
| <version>1.324</version> | ||
| <relativePath>../pom.xml</relativePath> | ||
| <version>1.519</version> |
There was a problem hiding this comment.
Is such a new version of Jenkins really required? E.g., try to use an old LTS version, e.g. 1.424.
There was a problem hiding this comment.
Sure, no problem.
|
Jenkins » tfs-plugin #14 SUCCESS |
olivierdagenais
added a commit
that referenced
this pull request
Jul 25, 2013
Upgrade plugin to parent version 1.424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the new SCM methods, including the new method of polling for changes.
Also refactored a bit of code to reduce duplication.
Manual testing:
mvnand copied the resultingtarget/tfs.hpito a Jenkins server running version 1.424, restarting it to make sure my version was picked up. (the Jenkins server is running under Windows)http://jenkins.example.com/pluginManager/installedand confirming that the version listed was 1.21-SNAPSHOT (private-06/24/2013 20:52-odagenais).42).http://jenkins.example.com/job/<jobName>/scmPollLog/until I saw that it ran. The log contains-version:C42~D2013-06-18T19:43:40Zwhich confirms the new polling method is being run. Awesome.Project pathto an entirely different path and saved the job again. Refreshed the Polling Log page until the "Started on" time was different. When it was different, this time the log didn't even include a call totf history, it completed in 6 ms with "Changes found". Double awesome. A build was automatically triggered, whose console output contained the lineDeleting workspace as the configuration has changed since a build was performed on this computer.. Recorded changeset number displayed in log (let's call it27).-version:C27~D2013-06-18T19:50:40ZMission accomplished!