Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for polling without needing a workspace #14

Merged
merged 9 commits into from
Jul 25, 2013
Merged

Add support for polling without needing a workspace #14

merged 9 commits into from
Jul 25, 2013

Conversation

olivierdagenais
Copy link
Member

This feature/improvement also avoids two problems:

  1. If some jobs use TFS as an SCM, are tied to certain nodes and none of those are available, the plugin would decide that because no workspace was available (for polling), it should queue a build to create one.
  2. In certain cases, asking the workspace what changeset it was at was returning erroneous results, causing the polling to think there still hadn't been a build for a recently-committed changeset.

@buildhive
Copy link

Jenkins » tfs-plugin #19 SUCCESS
This pull request looks good
(what's this?)

olivierdagenais added a commit that referenced this pull request Jul 25, 2013
@olivierdagenais
Merge pull request #14 from olivierdagenais/noWorkspaceWhenPolling
9bf737a 
Add support for polling without needing a workspace
@olivierdagenais olivierdagenais merged commit 9bf737a into jenkinsci:master Jul 25, 2013
@olivierdagenais olivierdagenais deleted the noWorkspaceWhenPolling branch July 25, 2013 20:12
@smile21prc smile21prc mentioned this pull request Jun 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@olivierdagenais @buildhive