Overwrite when getting files #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this maybe be an option ? |
|
Is there any problem if it always override? I'd find it strange if one build depends on the changes made by the previous one, but maybe I'm missing something. |
|
I am not sure. But we are changing current behavior of the plugin so it might be safer as an option. No idea what all our users are up to.. but I do like the idea of having this overwrite behaviour. |
|
I've agreed with @mosabua and I intended to implement this as a build option, but it kind of got lost. I'll create that option. |
|
@jpricketMSFT @mosabua Done |
|
I like it. Imho we should merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid problems when files are changed during the build.