Switch to TFS SDK and use it for obtaining detailed changeset info #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downloaded version 11.0.0.1306 (published 2013/06/21) from http://www.microsoft.com/en-us/download/details.aspx?id=22616 Needed to repeat parent dependencies due to the TFS SDK including its dependencies inside its JAR instead of being and using Maven artifacts.
This will allow users to be resolved earlier.
This should give us access to JenkinsRule.
This avoids having to add the com.microsoft.tfs.jni.native.base-directory property in the container's configuration file. Added an integration test to verify the functionality.
TFS should only be queried for a user's e-mail address the first time; the change will be persisted in Jenkins for subsequent times.
|
plugins » tfs-plugin #12 SUCCESS |
olivierdagenais
added a commit
that referenced
this pull request
Oct 23, 2013
Switch to TFS SDK and use it for obtaining detailed changeset info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project.getDetailedHistory()no longer launches thetfCLC but instead uses the TFS SDK for Java to communicate with the TFS webservices directly. This gives us richer information (such as e-mail addresses) with less string parsing.Manual testing:
EXAMPLE\ljenkinsdoes not imply their e-mail address isljenkins@example.comsince it could beleeroy.jenkins@example.com).users/sub-folder and noticing all the committers now have Jenkins users with their full name and e-mail address as configured in TFS.Mission accomplished!