Fix Multijob with same Subjob (with Alias) and add new nested build view for single build #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me job multiple times in same Multijob
|
@ptrsny , please resubmit after compilation errors fix and I'll be happy to merge |
|
@cohencil I am sorry for taking so much commits to finish but i am fairly new to maven and Java and so ^^'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112 #120
Fixed the flashing bubble problem. But if you make a Multijob a subjob of another subjob it will not work properly for the lowest jobs in the tree:
The compile and deploy jobs of MJNode(First) and MJNode(Second) will have the same ConsoleOutput link and the same bubble state, also when they do not run in parallel. But the different compile jobs are the same just with different parameters. (and different Alias in Brackets).
HINT: There is also a problem when you do not discard your old builds. At some point it will take very long to open a MultiJobView because it searches through the old ones. Maybe I can fix this later on.
Also I changed/added the tree view for a single MultiJob Build so you can see the full tree there too.