Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating code to build pipeline using multijob #167

Merged
merged 1 commit into from
Dec 24, 2018

Conversation

suvirp
Copy link

@suvirp suvirp commented Dec 18, 2018

This change will support pipeline jobs in a multijob job. Change was originally suggested by Simon Weber in https://issues.jenkins-ci.org/browse/JENKINS-38825. Can you please review and merge the change.

Change-Id: I837bc6e757c7b0dbcc90ee52823540fb8c4df8f1

Change-Id: I837bc6e757c7b0dbcc90ee52823540fb8c4df8f1
@yorammi
Copy link
Contributor

yorammi commented Dec 24, 2018

Thanks @suvirp for the pull request!
Since merging this pull request will force users to switch to Jenkins 2.31 and up, and there is a large usage of tikal-multijob-plugin on servers with Jenkins 1.x that are not planned to switch to 2.x servers, we must carefully consider whether to merge this PR, split the versions of the plugin or find another alternative.
Still, we see that many voted for the above-mentioned issue (and the matching issue: #152) and that many others also complain about not able to run pipeline jobs with multiJob.
Therefore, we'll check the PR and if works OK, we'll have a decision about how to merge it.

@yorammi
Copy link
Contributor

yorammi commented Dec 24, 2018

@suvirp I've tested locally you PR and it works fine as expected, running a pipeline job inside a mutiJob build.
Still, we'll consider how to merge it soon.

@suvirp
Copy link
Author

suvirp commented Dec 24, 2018

@suvirp I've tested locally you PR and it works fine as expected, running a pipeline job inside a mutiJob build.
Still, we'll consider how to merge it soon.

Ok, Thanks for considering my PR. Hope to see it get merged soon.

@yorammi yorammi merged commit 395ebb6 into jenkinsci:master Dec 24, 2018
@yorammi
Copy link
Contributor

yorammi commented Dec 24, 2018

@suvirp It's been approved to merge the PR. Soon we'll release a new version.

@suvirp
Copy link
Author

suvirp commented Dec 24, 2018 via email

@yorammi
Copy link
Contributor

yorammi commented Dec 26, 2018

Version 1.32 released and contains this PR of @suvirp

@suvirp
Copy link
Author

suvirp commented Dec 26, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants