Reuse successfully subbuilds from previous build [JENKINS-19524]

[sshelomentsev]

https://issues.jenkins-ci.org/browse/JENKINS-19524

[sshelomentsev]

Hi!
I've implemented a feature related to https://issues.jenkins-ci.org/browse/JENKINS-19524
In case of any phase ended with status FAILED, it provided an opportunity to reuse successfully completed sub jobs in the new build.

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[emoshaya]

Definitely a great PR!! Hopefully this gets merged soon!

[rexim]

👍

I hope this PR will be merged. :)

[oleg-nenashev]

NiT: as I see the plugin mostly uses spaces for the tabulation. It would be better to follow this approach

[oleg-nenashev]

I need only indicate the cause of the original build in the new build. Is it true, if a build started by a user or by a trigger, then cause will always be one?

Actually no. There may be many causes of different and/or similar types. A common example is Rebuild plugin, which adds an additional cause without modifying previous ones

[sshelomentsev]

Hi @hagzag!
Thanks for merge my PR. When do you plan to release?

[emoshaya]

Hi @sshelomentsev
I have just tested this feature
I have a phase with 2 jobs, I have configured one of them to fail.
I see that after I fixed the cause of failure, the successful job from the previous run, is still being triggered and not reused.

what am I missing ?
Thanks

I have the same issue. Exactly how do we reuse the previous successful build? Is there a postbuild action we need to enable

[sshelomentsev]

Hi @ebrahim-moshaya
I'm missing a clarification for ...
You can reuse successful build by clicking "resume builds" link in build page.

[emoshaya]

Hi @sshelomentsev Thank you for the screenshot. Stupidly I was not using the plugin from your branch.. I need to rebuild the plugin to be able to use it. Thanks for your help!!

[emoshaya]

@sshelomentsev By the way, It would be really really nice if this plugin allowed for the build to pause after a certain phase waiting for manual promotion/resume. This would allow for phases requiring manual deployments to be included in the multijob. Unfortunately, we are having to use the promoted builds plugin in the multijob to trigger another job for deployment of the application. Unfortunately, this means the deployment job and post deployment jobs are missing from the visual pipeline and is not represented in the multijob phases. The workflow plugin already allows for a phase to pause and for it to resume following manual input.

[shacharbz]

Hi @sshelomentsev

I have a problem with re-running a failed job
If my build is parameterized, the resumed build won't use the params I passed in the initial run.

[sshelomentsev]

Hi @shacharbz
I found that I forgot about copying a parameters actions. Fix it now. Pull-request for it #77

[shacharbz]

@sshelomentsev
Thanks for quick response! testing it now.

[shacharbz]

works ok now, PR merged, Thanks again!

[dcendents]

Any reason why we cannot resume an UNSTABLE build?

The way I configure my jobs, when a build is not STABLE, most of the time it is UNSTABLE and rarely FAILED.
i.e.: Some tests failed but otherwise the project did build correctly.

I don't mind doing a PR myself to add the feature, but maybe there's a good reason why it was not done this way?

I'd appreciate your input.

Thanks

[sshelomentsev]

@dcendents
I missed the case for UNSTABLE build. It's because in our environment we handle FAILED or UNSTABLE build runtime and manually set status FAILURE by user action.
So, no reason not to make this.

[emoshaya]

Hi The overall build below is red because child job Update Services - Cucumber Tests is red. I expected resuming this build will resume from the unstable or red child jobs. However, resuming this build restarts the build from the first Multijob phase API Gateway - Maven Build...