Fix warnings (#233)

jenkinsci · Mar 24, 2023 · 05f1320 · 05f1320
1 parent d309e4c
commit 05f1320
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/src/main/java/hudson/plugins/timestamper/TimestamperConfig.java b/src/main/java/hudson/plugins/timestamper/TimestamperConfig.java
@@ -44,9 +44,11 @@
 import javax.servlet.ServletException;
 import jenkins.YesNoMaybe;
 import jenkins.model.GlobalConfiguration;
+import jenkins.model.Jenkins;
 import org.apache.commons.lang3.time.DurationFormatUtils;
 import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.QueryParameter;
+import org.kohsuke.stapler.verb.POST;
 
 /**
  * Global configuration for the Timestamper plug-in, as shown on the Jenkins Configure System page.
@@ -111,8 +113,11 @@ public void setSystemTimeFormat(@CheckForNull String timestampFormat) {
     save();
   }
 
+  @POST
   public FormValidation doCheckSystemTimeFormat(@QueryParameter String systemTimeFormat)
       throws IOException, ServletException {
+    Jenkins.get().checkPermission(Jenkins.ADMINISTER);
+
     if (Util.fixEmptyAndTrim(systemTimeFormat) == null) {
       return FormValidation.ok();
     }
@@ -140,8 +145,11 @@ public void setElapsedTimeFormat(@CheckForNull String elapsedTimeFormat) {
     save();
   }
 
+  @POST
   public FormValidation doCheckElapsedTimeFormat(@QueryParameter String elapsedTimeFormat)
       throws IOException, ServletException {
+    Jenkins.get().checkPermission(Jenkins.ADMINISTER);
+
     if (Util.fixEmptyAndTrim(elapsedTimeFormat) == null) {
       return FormValidation.ok();
     }

diff --git a/src/main/java/hudson/plugins/timestamper/action/TimestampsAction.java b/src/main/java/hudson/plugins/timestamper/action/TimestampsAction.java
@@ -77,6 +77,7 @@ public String getUrlName() {
   }
 
   /** Serve a page at this URL. */
+  @SuppressWarnings({"lgtm[jenkins/csrf]", "lgtm[jenkins/no-permission-check]"})
   public void doIndex(StaplerRequest request, StaplerResponse response) throws IOException {
     response.setContentType("text/plain;charset=UTF-8");
 

diff --git a/src/main/java/hudson/plugins/timestamper/pipeline/TimestamperStep.java b/src/main/java/hudson/plugins/timestamper/pipeline/TimestamperStep.java
@@ -130,6 +130,7 @@ public String getHelpFile() {
 
     /** Serve the help file. */
     @Override
+    @SuppressWarnings({"lgtm[jenkins/csrf]", "lgtm[jenkins/no-permission-check]"})
     public void doHelp(StaplerRequest request, StaplerResponse response) throws IOException {
       response.setContentType("text/html;charset=UTF-8");
       PrintWriter writer = response.getWriter();