[JENKINS-55956] Replace DatatypeConverter.printHexBinary call with local helper method. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
approved these changes
Mar 21, 2019
There was a problem hiding this comment.
It is generally OK, but there should be libs supporting it in the plugin. E.g. https://commons.apache.org/proper/commons-codec/apidocs/org/apache/commons/codec/binary/Hex.html
Does not matter for the test code tho
CC @jenkinsci/java11-support
batmat
approved these changes
Mar 21, 2019
|
@dwnusbaum @jglick given the last commits, you might be the current maintainer(s)? I think this is ready for merge. Thanks! |
MRamonLeon
approved these changes
Mar 22, 2019
jglick
approved these changes
Mar 29, 2019
| @@ -161,7 +159,7 @@ public void testHashFile() throws Exception { | |||
| byte[] expectedHash = MessageDigest.getInstance("SHA-1").digest(fileContents); | |||
| assertThat( | |||
| Files.toString(timestampsHashFile, Charsets.US_ASCII).trim(), | |||
| is(DatatypeConverter.printHexBinary(expectedHash).toLowerCase())); | |||
| is(bytesToHex(expectedHash).toLowerCase())); | |||
There was a problem hiding this comment.
BTW always pass Locale.ROOT as the argument here, to avoid messing with Turkish developers. OTOH this is just test code and I suppose we should make the parent POM set the root locale in Surefire.
jglick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to remove dependency on JAXB from this plugin, I added a local method that does the same thing as DatatypeConverter.printHexBinary and called the local method instead.
Original ticket in Jenkins JIRA: https://issues.jenkins-ci.org/browse/JENKINS-55956