[JENKINS-42959] Return host algorithms if in known_host and we support them #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paladox
approved these changes
Apr 3, 2017
|
Would this be able to be merged please? |
|
The tests patch has been merged :) |
|
@mc1arke Can this be merged or should we wait 24 hours? |
|
The 24 hours I wait is a minimum time which is long past on this. As this is a small change I'm fairly comfortable that a further review of this isn't essential, however I'm working on other requests just now so will only merge this once I have time to focus on this properly. |
|
ok thanks :) |
mc1arke
force-pushed
the
JENKINS-42959-identify-supported-known-host-keys
branch
from
7733cf2
to
41554f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently calling
KnownHosts.getPreferredServerHostkeyAlgorithmOrder(String)always returns null since the initialpreferredAlgovariable is set to null and never updated. This prevents this method being any use for identifying preferred algorithms to use for the likes of JENKINS-42959.Probably a good idea to merge #10 first to allow tests to be executed