[JENKINS-44120] Prevent NPE when using DH group 1 or 14 with SHA1 KEX #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robberphex
pushed a commit
to robberphex/trilead-ssh2
that referenced
this pull request
Feb 22, 2019
Fix eddsa tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trilead currently tries to read a sub-field of the field it's trying to set whilst creating the Key Exchange Parameters for diffie-hellman-group1-sha1 and diffie-hellman-group14-sha1. This causes a NullPointerException as the field being read can only ever by null at this point. This PR modifies Trilead to use a hardcoded reference to
SHA1at this point since the algorithm can only ever be using SHA1 in this scenario.