Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github action #5

Merged
merged 1 commit into from Dec 14, 2021
Merged

Added github action #5

merged 1 commit into from Dec 14, 2021

Conversation

tomjshore
Copy link
Contributor

Added Github action to release when pushing to master

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

id: interesting-categories
if: steps.verify-ci-status.outputs.result == 'success'
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need output_result: true if it is used in steps.verify-ci-status.outputs.result == 'success' && steps.interesting-categories.outputs.interesting == 'true'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have copied the workflow from here https://github.com/jenkinsci/.github/blob/master/workflow-templates/cd.yaml

like the documentation says Create .github/workflows/cd.yaml as a copy of the cd.yaml template.

@tomjshore tomjshore added the dependencies Pull requests that update a dependency file label Dec 14, 2021
@tomjshore tomjshore merged commit 076e95f into master Dec 14, 2021
@daniel-beck
Copy link
Member

daniel-beck commented Dec 14, 2021

There's an extra - in the version number: 1.1--rc18.076e95fd3443 due to

<version>${revision}-${changelist}</version>
, compare https://github.com/jenkinsci/incrementals-tools/

This looks incorrectly incrementalized since it's an rc. Unsure so far why…

@daniel-beck
Copy link
Member

@jglick Any idea why the version is an RC in http://updates.jenkins.io/download/plugins/uleska/ ? I checked incrementals docs and other than the extra -, it looks correct.

@jglick
Copy link
Member

jglick commented Dec 14, 2021

The steps in https://www.jenkins.io/doc/developer/publishing/releasing-cd/#pom-file-modifications were omitted.

@tomjshore
Copy link
Contributor Author

oh thank you @daniel-beck and @jglick I see what I have done wrong now. I will make a new change to the pom file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
4 participants