New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added github action #5
Conversation
id: interesting-categories | ||
if: steps.verify-ci-status.outputs.result == 'success' | ||
with: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also need output_result: true
if it is used in steps.verify-ci-status.outputs.result == 'success' && steps.interesting-categories.outputs.interesting == 'true'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have copied the workflow from here https://github.com/jenkinsci/.github/blob/master/workflow-templates/cd.yaml
like the documentation says Create .github/workflows/cd.yaml as a copy of the cd.yaml template.
There's an extra Line 12 in 076e95f
This looks incorrectly incrementalized since it's an |
@jglick Any idea why the version is an RC in http://updates.jenkins.io/download/plugins/uleska/ ? I checked incrementals docs and other than the extra |
The steps in https://www.jenkins.io/doc/developer/publishing/releasing-cd/#pom-file-modifications were omitted. |
oh thank you @daniel-beck and @jglick I see what I have done wrong now. I will make a new change to the pom file. |
Added Github action to release when pushing to master