fixed warnings

jenkinsci · Mar 5, 2018 · dbc644e · dbc644e
1 parent 80beb27
commit dbc644e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/valgrind/ValgrindProjectAction.java b/src/main/java/org/jenkinsci/plugins/valgrind/ValgrindProjectAction.java
@@ -14,11 +14,13 @@ protected ValgrindProjectAction(Job<?, ?> project)
 		super(project);
 	}
 
+	@Override
 	public String getDisplayName()
 	{
 		return "Valgrind Results";
 	}
 
+	@Override
 	public String getUrlName()
 	{
 		return ValgrindBuildAction.URL_NAME;
@@ -39,10 +41,10 @@ public String getUrlName()
 	@Override
 	public Integer getLastResultBuild()
 	{
-		for (Run<?, ?> b = (Run<?, ?>) getJob().getLastBuild(); b != null; b = b.getPreviousBuiltBuild())
+		for (Run<?, ?> b = getJob().getLastBuild(); b != null; b = b.getPreviousBuiltBuild())
 		{
 			ValgrindBuildAction r = b.getAction(ValgrindBuildAction.class);
-			
+
 			if (r != null)
 				return b.getNumber();
 		}
@@ -59,7 +61,7 @@ public final boolean isDisplayGraph()
 		// Affect previous
 		for (b = b.getPreviousBuild(); b != null; b = b.getPreviousBuild())
 		{
-			if (b.getResult().isWorseOrEqualTo(Result.FAILURE))
+			if (b.getResult() == null || b.getResult().isWorseOrEqualTo(Result.FAILURE))
 				continue;
 
 			ValgrindBuildAction action = b.getAction(ValgrindBuildAction.class);

diff --git a/src/main/java/org/jenkinsci/plugins/valgrind/ValgrindResult.java b/src/main/java/org/jenkinsci/plugins/valgrind/ValgrindResult.java
@@ -26,7 +26,7 @@ public class ValgrindResult implements Serializable
 	private static final String PID_TOKEN = "pid=";
 
     private ValgrindParserResult parser;
-    private Run<?, ?> owner;
+    private transient Run<?, ?> owner;
     private Map<String, String> sourceFiles;
 
     public ValgrindResult( Run<?, ?> build, ValgrindParserResult parser)