[JENKINS-68147] Support Java 17 #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to be merged? |
|
FWIW this still doesn't work with the version coming from a macos node: |
basil
requested changes
Nov 10, 2022
pom.xml
Outdated
Comment on lines
61
to
65
| <dependency> | ||
| <groupId>org.jenkins-ci</groupId> | ||
| <artifactId>version-number</artifactId> | ||
| <version>1.10</version> | ||
| </dependency> |
There was a problem hiding this comment.
This is already included in Jenkins core as of 2.342, so rather than duplicate the library in this plugin, I suggest bumping the core baseline to 2.346 or later.
There was a problem hiding this comment.
Something like deleting this new dependency and instead doing:
diff --git a/pom.xml b/pom.xml
index 22f57f5..573bf80 100644
--- a/pom.xml
+++ b/pom.xml
@@ -51,15 +51,15 @@
<properties>
<revision>2.3</revision>
<changelist>-SNAPSHOT</changelist>
- <jenkins.version>2.277.4</jenkins.version>
+ <jenkins.version>2.346.1</jenkins.version>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
- <artifactId>bom-2.277.x</artifactId>
- <version>984.vb5eaac999a7e</version>
+ <artifactId>bom-2.346.x</artifactId>
+ <version>1382.v7d694476f340</version>
<scope>import</scope>
<type>pom</type>
</dependency>
Null pointer exception may still be thrown by the called method, need to preserve functionality.
basil
reviewed
Nov 10, 2022
Comment on lines
+71
to
+72
| {"1.8.0", JavaSpecificationVersion.JAVA_6.toReleaseVersion()}, | ||
| {"11.0.1", JavaSpecificationVersion.JAVA_11.toReleaseVersion()}, |
There was a problem hiding this comment.
Why aren't these toClassVersion? This parameter represents a class version, not a release version.
src/test/java/hudson/plugin/versioncolumn/JVMVersionComparatorTest.java
Outdated
Show resolved
Hide resolved
MarkEWaite
changed the title
|
Superseded by #88 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-68147 Support Java 17
Add support of JDK17 using org.jenkins-ci:version-number library