Correction of JENKINS 12764 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Un-needed @OverRide removed. Compiling version.
|
Looks like your pull requests include several unrelated commit. I guess you only want to include b25c6e5 "2 methods overriden for jelly to see them." |
|
There is also 8a2ee87 which change the sourcefile path from Absolute to a relative path. |
|
Sorry didn't see your pull request comments... you were right there was too much commit on this pull request... it was my first. As I understand the proper code has been merged? can i close this pull request or something like that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-12764
Quick correction: 2 methods weren't seen by Jelly.
Not a specialist, i've just overriden them.
Jenkins targeted version: 1.451