Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-66301] Prepare vSphere for core Guava upgrade #128

Merged
merged 1 commit into from Aug 13, 2021

Conversation

basil
Copy link
Member

@basil basil commented Aug 8, 2021

See JENKINS-65988 and JENKINS-66301. Jenkins core is using Guava 11.0.1, which was released on January 9, 2012. Jenkins core would like to upgrade to Guava 30.1.1, which was released on March 19, 2021. Plugins must be prepared to be compatible with both Guava 11.0.1 and Guava 30.1.1 in advance of this core transition.

In particular, this plugin has been identified as using the com.google.common.base.Stopwatch API, which has changed between Guava 11.0.1 and latest. The following methods exist in Guava 11.0.1 but not latest:

  • Stopwatch#elapsedMillis()
  • Stopwatch#elapsedTime(TimeUnit desiredUnit)
  • Stopwatch#toString(int significantDigits)

To facilitate the Jenkins core transition, this plugin must be prepared and released such that it works with both Guava 11.0.1 and latest. This PR migrates away from the Stopwatch API and uses System#nanoTime directly.

@pjdarton pjdarton merged commit 6c10b17 into jenkinsci:master Aug 13, 2021
@basil basil deleted the guava branch August 14, 2021 18:58
@basil
Copy link
Member Author

basil commented Aug 14, 2021

@pjdarton Thanks! Could this please be released? This would help facilitate the Guava upgrade effort in Jenkins core.

@pjdarton
Copy link
Member

Released just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants