This repository has been archived by the owner on Apr 6, 2022. It is now read-only.
[Feature] Category filtering #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 6, 2017 13:51
…d mixture pattern
…ibute for matching.
uhafner
reviewed
May 15, 2017
| @@ -118,7 +118,7 @@ | |||
| <connection>scm:git:git://github.com/jenkinsci/${project.artifactId}-plugin.git</connection> | |||
| <developerConnection>scm:git:git@github.com:jenkinsci/${project.artifactId}-plugin.git</developerConnection> | |||
| <url>https://github.com/jenkinsci/${project.artifactId}-plugin</url> | |||
| <tag>HEAD</tag> | |||
| <tag>warnings-4.61</tag> | |||
There was a problem hiding this comment.
Did you check if the ATH test still is running after the UI changes?
There was a problem hiding this comment.
Ah sorry, I might have changed the tag to be able to create an installable hpi for our server. Should I leave it as HEAD?
I will also check the test suite again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this might break existing jobs but in my opinion it is just wrong and could be considered a bug. You can not use commas in the regex, it is not a real regex etc.
Includes a small unit test and was tested on our local instance with GCC and Clang parsers.