Make test less flaky #229
Merged
Make test less flaky #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
reviewed
Jun 23, 2022
| @@ -40,6 +40,7 @@ public void testSimpleConnection() throws Exception { | |||
| makeRequest("http://localhost:"+port+"/examples/CountRequestsServlet"); | |||
|
|
|||
| // check the log file | |||
| Thread.sleep(5000); | |||
There was a problem hiding this comment.
would be better to add a loop retrying every maybe 100ms then if keep failing after 5000ms
because this add unconditionally 5s to the build
There was a problem hiding this comment.
I am not interested in doing that.
There was a problem hiding this comment.
recorded in #231 for future improvement
|
why making a PR if you do not wait for review? |
|
I am not interested. |
sounds like a polite, technical and community oriented answer.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding this sleep, this test would flake about half the time as in this run. After adding this sleep I have run the test 10 times in a row without any flakes.