Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECMAScript (Javascript) modules MIME type #329

Merged
merged 1 commit into from Jun 20, 2023

Conversation

danlenar
Copy link
Contributor

Add ECMAScript (Javascript) modules mime.

Other folks might benefit from having the mjs content-type enabled by default as folks might be publishing html reports of javascript containing the mjs extension.

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is consistent with js=application/javascript above, this page states that text/javascript is to be preferred over application/javascript, which matches the default configuration of upstream Jetty and Apache httpd (but not Nginx). I think I have a slight preference for updating the js= and mjs= lines in this file to use text/javascript rather than application/javascript.

@basil basil changed the title Add ECMAScript (Javascript) modules mime Add ECMAScript (Javascript) modules MIME type Jun 15, 2023
Use text/javascript over application/javascript as
application/javascript is deprecated

Signed-off-by: Daniel Lenar <dlenar@vailsys.com>
@danlenar
Copy link
Contributor Author

@basil

I updated js and mjs to use text/javascript

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit c610823 into jenkinsci:master Jun 20, 2023
14 checks passed
@basil
Copy link
Member

basil commented Jun 20, 2023

Released in 6.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants