Use the DescribableModel.of method to avoid extra object creation

jenkinsci · Apr 11, 2018 · bf26059 · bf26059
1 parent 5778fc9
commit bf26059
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -136,7 +136,7 @@
         <dependency>
             <groupId>org.jenkins-ci.plugins</groupId>
             <artifactId>structs</artifactId>
-            <version>1.7</version>
+            <version>1.14</version>
         </dependency>
     </dependencies>
 </project>
diff --git a/src/main/java/org/jenkinsci/plugins/workflow/actions/ArgumentsAction.java b/src/main/java/org/jenkinsci/plugins/workflow/actions/ArgumentsAction.java
@@ -292,9 +292,9 @@ public boolean isUnmodifiedArguments() {
             StepDescriptor d = ((StepNode) n).getDescriptor();
             if (d != null) {
                 try {
-                    return resolve(new DescribableModel<>(d.clazz), args).getArguments();
+                    return resolve(DescribableModel.of(d.clazz), args).getArguments();
                 } catch (Exception x) { // all sorts of things could go wrong here
-                    LOGGER.log(Level.FINE, "coult not resolve " + args + " for " + d.clazz.getName(), x);
+                    LOGGER.log(Level.FINE, "could not resolve " + args + " for " + d.clazz.getName(), x);
                     // TODO this does not handle NotStoredReason’s well
                     // more robust to recursively traverse the tree and use e.g. DescribableModel.resolveClass to populate details
                     // (without actually attempting to instantiate any of the classes)