Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Java 21 #299

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Test on Java 21 #299

merged 1 commit into from
Aug 16, 2023

Conversation

NotMyFault
Copy link
Member

No description provided.

@NotMyFault NotMyFault requested a review from a team August 12, 2023 18:19
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dropping test coverage on 11, which seems wrong. Suggest running tests on 11 & 21.

@basil
Copy link
Member

basil commented Aug 14, 2023

A suggestion made without reasoning and inconsistent with the archetype. Should the suggestion be ignored without reasoning as well?

@jglick
Copy link
Member

jglick commented Aug 14, 2023

Ah, never saw jenkinsci/archetypes#651.

@basil
Copy link
Member

basil commented Aug 14, 2023

The reasoning behind dropping Java 11 from the archetype: since implementing a migration of this nature across the whole ecosystem involves so much code change and since Java 11 will likely be EOL in about a year, it is globally more efficient to do one pass through the ecosystem adding 21 and dropping 11 rather than two passes through the ecosystem separated in time by about a year. Since Java versions have gotten more strict over time rather than less strict, it is unlikely for a bug to be present when running on 11 but not 17 or 21.

@jglick jglick merged commit 19ac763 into jenkinsci:master Aug 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants