Do not test branch ordering with ForkScanner for incomplete build with nested parallelism #310

dwnusbaum · 2023-09-11T18:07:32Z

See #306 (comment).

Testing done

Submitter checklist

Give feedback

Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure that the pull request title represents the desired changelog entry

Ensure that the pull request title represents the desired changelog entry
Options
Successfully updated the issue's project

There was an error updating the issue's project
Please describe what you did

Please describe what you did
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant issues in GitHub or Jira

Link to relevant issues in GitHub or Jira
Options
Successfully updated the issue's project

There was an error updating the issue's project
Link to relevant pull requests, esp. upstream and downstream changes

Link to relevant pull requests, esp. upstream and downstream changes
Options
Successfully updated the issue's project

There was an error updating the issue's project
Ensure you have provided tests - that demonstrates feature works or fixes the issue

Ensure you have provided tests - that demonstrates feature works or fixes the issue
Options
Successfully updated the issue's project

There was an error updating the issue's project
Options

…h nested parallelism

dwnusbaum · 2023-09-11T18:08:39Z

src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScannerTest.java

@@ -1029,7 +1029,8 @@ public void inProgressParallelInParallel() throws Exception {
        SemaphoreStep.waitForStart("innerA/1", b);
        ForkScanner scanner = new ForkScanner();
        sanityTestIterationAndVisiter(b.getExecution().getCurrentHeads());
-        assertBranchOrder(b.getExecution(), "innerB", "innerA", "outerC", "outerB", "outerA");
+        // Observed to flake with innerA coming first in some cases.
+        // assertBranchOrder(b.getExecution(), "innerB", "innerA", "outerC", "outerB", "outerA");


I think that the flakiness is just because the build was incomplete and the similar assertion a few lines below should be consistent. Not 100% sure though.

src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScannerTest.java

Do not test branch ordering with ForkScanner for incomplete build wit…

95b7a74

…h nested parallelism

dwnusbaum requested a review from a team as a code owner September 11, 2023 18:07

dwnusbaum commented Sep 11, 2023

View reviewed changes

jglick added the tests label Sep 11, 2023

jglick approved these changes Sep 11, 2023

View reviewed changes

jglick merged commit 526907f into jenkinsci:master Sep 11, 2023
14 checks passed

dwnusbaum deleted the flaky-test branch September 11, 2023 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not test branch ordering with ForkScanner for incomplete build with nested parallelism #310

Do not test branch ordering with ForkScanner for incomplete build with nested parallelism #310

dwnusbaum commented Sep 11, 2023

Submitter checklist

dwnusbaum Sep 11, 2023

Do not test branch ordering with ForkScanner for incomplete build with nested parallelism #310

Do not test branch ordering with ForkScanner for incomplete build with nested parallelism #310

Conversation

dwnusbaum commented Sep 11, 2023

Testing done

Submitter checklist

dwnusbaum Sep 11, 2023

Choose a reason for hiding this comment