Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and rewrite LocalData for a test #79

Merged
merged 1 commit into from Mar 8, 2019

Conversation

@dwnusbaum
Copy link
Member

commented Jan 18, 2019

Analogous to jenkinsci/pipeline-input-step-plugin#31.

Most notable change is that I rewrote the @LocalData for a test to be compatible with workflow-support 3.0. I rewrote it instead of deleting it since looking through the history it looks like the test was added as a regression test to avoid unintended changes to the serialized form rather than to fix a specific issue, so it seems fine to have a similar regression test going forward.

@abayer
abayer approved these changes Mar 8, 2019
@dwnusbaum dwnusbaum merged commit 54f9f13 into jenkinsci:master Mar 8, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/incrementals Deployed to Incrementals.
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@dwnusbaum dwnusbaum deleted the dwnusbaum:pct-cleanup branch Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.