Merge pull request #72 from jglick/params-ro

Clarify and enforce that params is read-only
jenkinsci · Oct 10, 2016 · 5d5ebc6 · 5d5ebc6
2 parents db68b70 + a460bdb
commit 5d5ebc6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/org/jenkinsci/plugins/workflow/cps/ParamsVariable.java b/src/main/java/org/jenkinsci/plugins/workflow/cps/ParamsVariable.java
@@ -80,7 +80,7 @@
             }
             values.put(parameterValue.getName(), value);
         }
-        return values;
+        return Collections.unmodifiableMap(values);
     }
 
 }
diff --git a/src/main/resources/org/jenkinsci/plugins/workflow/cps/ParamsVariable/help.jelly b/src/main/resources/org/jenkinsci/plugins/workflow/cps/ParamsVariable/help.jelly
@@ -26,7 +26,7 @@ THE SOFTWARE.
 <?jelly escape-by-default='true'?>
 <j:jelly xmlns:j="jelly:core">
     <p>
-        Exposes all parameters defined in the build as a map with variously typed values. Example:
+        Exposes all parameters defined in the build as a read-only map with variously typed values. Example:
     </p>
     <pre><code>if (params.BOOLEAN_PARAM_NAME) {doSomething()}</code></pre>
 </j:jelly>