Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose assertGenerateSnippet to pipeline-model-definition #362

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Expose assertGenerateSnippet to pipeline-model-definition #362

merged 2 commits into from
Jun 17, 2020

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Jun 16, 2020 •
edited
Loading

This was referenced Jun 16, 2020
Merged
Merged
@Vlatombe @jglick
Update src/main/java/org/jenkinsci/plugins/workflow/cps/Snippetizer.java
c749116 
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@Vlatombe Vlatombe closed this Jun 17, 2020
@Vlatombe Vlatombe reopened this Jun 17, 2020
@dwnusbaum
Copy link
Member

Hmm, I have seen RestartingLoadStepTest.updateBindingsOnRestart flake a few times recently. I think that after the restart the PlaceholderExecutable for the node step is still present in the program and starts executing (not sure exactly why, based on the logs it looks like it already completed, maybe program.dat isn't saved consistently?), and so this line in PlaceholderExecutable.run fails since the flow node for the node step is already marked as completed.

@dwnusbaum dwnusbaum closed this Jun 17, 2020
@dwnusbaum dwnusbaum reopened this Jun 17, 2020
@Vlatombe
Copy link
Member Author

Yeah it passed in https://ci.jenkins.io/job/Plugins/job/workflow-cps-plugin/job/PR-362/2/ anyway. Just wanted to have a clean green status, looks like it's not happening.

@dwnusbaum dwnusbaum merged commit 455249a into jenkinsci:master Jun 17, 2020
@Vlatombe Vlatombe deleted the expose-assertGenerateSnippet branch June 23, 2020 08:38
@Vlatombe
Copy link
Member Author

@dwnusbaum do you plan on cutting a release for this plugin soon? I'd like to move forward with the downstream changes

@dwnusbaum
Copy link
Member

@Vlatombe Yes, I was hoping to get #361 and #363 into the next release, but there have been a ton of infra issues lately so the builds aren't passing.

@dwnusbaum dwnusbaum mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@dwnusbaum dwnusbaum dwnusbaum approved these changes

@kerogers-cloudbees kerogers-cloudbees kerogers-cloudbees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Vlatombe @dwnusbaum @jglick @kerogers-cloudbees