[JENKINS-63164] Clear fields in CpsThread when thread is removed from CpsThreadGroup #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
approved these changes
Jul 22, 2020
bitwiseman
reviewed
Jul 22, 2020
| @@ -419,6 +419,7 @@ private boolean run() { | |||
| t.fireCompletionHandlers(o); // do this after ErrorAction is set above | |||
|
|
|||
| threads.remove(t.id); | |||
| t.cleanUp(); | |||
There was a problem hiding this comment.
I think I like this better than #367 because it seems like there's fewer paths in which this call could be missed but I might not be understanding.
jglick
reviewed
Jul 22, 2020
|
@bitwiseman I added some assertions for The other fields we clean up are all nullable, so it doesn't really make sense to add assertions around them. |
car-roll
approved these changes
Jul 23, 2020
olamy
approved these changes
Jul 24, 2020
Merged
dwnusbaum
added a commit
to dwnusbaum/workflow-cps-plugin
that referenced
this pull request
Aug 11, 2020
Underlying issue was fixed by jenkinsci#368.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #367. This is the first alternative discussed in #367 (comment).